enable locally runnable CI by CobaltCause · Pull Request #2983 · LemmyNet/lemmy
github.com
And a handful of other things. The commit messages are extremely detailed, so please have a look at those. That said, I'll highlight the main points of the PR here: Currently, Lemmy's CI pi...

Dessalines: :bugs-no:

I'm sure his ideas have advantages and the lemmy devs can be frustrating to work with but he literally showed up yesterday spamming the matrix chat and now this

  • captcha [any]
    ·
    2 years ago

    Typical good intentioned contributed couldn't handle that there were also good reasons for not accepting their contributions.

    Fast CI is good. Locally runnable CI is basically a necessity if you want keep your CI well maintained. Lemmy's CI sounds like an absolute nightmare to change. If you can't run it locally then you have to commit and push your changes and keep refreshing a website to see if it works. If this takes +40min then you literally can't hack on it for any extended period of time unless you have deep brain understanding of the CI system which basically no one does.

    • Aceivan [they/them]
      ·
      2 years ago

      Yeah. The thing was he asked about doing this in the matrix before he put the PR together and was essentially given an unequivocal "no" at that time as well

      I don't think the CI is 100% necessary for local development and I think you can run woodpecker locally if you wanted, but yeah the runtimes are dog slow and there's lots of room for improvement, this guy is just being a jerk about it

      • captcha [any]
        ·
        2 years ago

        Local CI only for CI development. You keep your CI simple and use docker and some sort of build scripts like gnu make to do local development.

        Never heard of woodpecker though. New thing to read up on.

        Edit from woodpecker docs:

        Plugins are Docker images with your script as an entrypoint

        NOW THIS IS PODRACING

        • Aceivan [they/them]
          ·
          2 years ago

          You can build lemmy just fine locally. I think maybe it just doesn't run the test suite unless you use the CI? So I guess the real question is do you need the test suite in the loop for every build. I can see where it'd be nice but I'm barely even a dev so idk

          • captcha [any]
            ·
            2 years ago

            Test suites should be runnable locally. It encourages people to write tests and check then before submitting a pr. But it makes sense for running it in CI to be first priority on an open source project.