Mine is Faraam from ds2. There's something about the ds2 vibe and aesthetic that I find so appealing. Also this armour just looks so good.
Runner up is fallen knight set from ds3 cos it looked really cool when embered and Lautrecs from ds1 cos bronz. Fluted set from demons is also very good.
Dark Souls 2 had some good armor sets. I think my fashion souls for that game was Havel Gloves, one of the DLC crowns, and Throne Watcher set