If they had like a 64x64px preview that you could open if you wanted to thatd be fine but having like 1080p gifs pop up is too much. And some wrecker is going to use it to post something horrible sooner or later.
tbf most of them aren't even that big data wise, like that one above was like 200kB. they just render huge, which will be addressed when the devs aren't fried from working all weekend to get this thing fast and stable (knock on wood)
I might open an issue or try to throw together a PR to just have the inline images be a user setting. They're just rendered markdown.
I think the only issue is that emotes are now being handled through markdown and pictrs so there'd have to be a way to limit that.
Also inline images is a big no no. Spamming posts is one thing, but now a malicious user could spam terrible images in comment chains that take up your full screen and can't be NSFW filtered.
There is some unique risks to allowing inline images, yeah. but I'm deferring to the people with moderation experience on this one. if they want it gone it will be gone.
and we already limit inline images to only whitelisted domains so it's definitely possible to filter things.
This will all be worked out in time, is been really cool seeing everyone so active again. It feels like the site is coming back to life a bit as we're figuring out all the new stuff. Also seems like we woke up some people with programming experience that can maybe help out which would be nice.
Sadly it is necessary right now for emotes. Our old system would break federation so we had to switch to using pictrs instead of our custom renderer. Basically all emotes are now just online images that are made to be small.
So there's a way for the emotes to be separated from inline images without just looking at the markdown formatting? That's good.
In that case couldn't the images just be switched from rendered to rendered as a link (e.g. inline image) pretty easily. That would also make having a user setting toggle pretty easy right? Just choose how you want to render them.
I profoundly dislike the images in comments. Scrolling down and finding an animu picture covering the whole screen is jarring.
deleted by creator
Yes this is an animu covering the whole screen and it is jarring.
I am blocking you.
I was about to add one twice as long but I'm "rate limited" :(
Oh yeah there should probably be a size cap or something
If they had like a 64x64px preview that you could open if you wanted to thatd be fine but having like 1080p gifs pop up is too much. And some wrecker is going to use it to post something horrible sooner or later.
I agree about the preview, you should have to opt in before someone can consume a ton of your data like that. Make it the size of an emote.
Oh I didn't even think about that. Yeah, it'll add up over the month if people are spamming giant gifs.
tbf most of them aren't even that big data wise, like that one above was like 200kB. they just render huge, which will be addressed when the devs aren't fried from working all weekend to get this thing fast and stable (knock on wood)
I might open an issue or try to throw together a PR to just have the inline images be a user setting. They're just rendered markdown.
I think the only issue is that emotes are now being handled through markdown and pictrs so there'd have to be a way to limit that.
Also inline images is a big no no. Spamming posts is one thing, but now a malicious user could spam terrible images in comment chains that take up your full screen and can't be NSFW filtered.
There is some unique risks to allowing inline images, yeah. but I'm deferring to the people with moderation experience on this one. if they want it gone it will be gone.
and we already limit inline images to only whitelisted domains so it's definitely possible to filter things.
This will all be worked out in time, is been really cool seeing everyone so active again. It feels like the site is coming back to life a bit as we're figuring out all the new stuff. Also seems like we woke up some people with programming experience that can maybe help out which would be nice.
Would discord style nsfw detection be possible/realistic?
Probably not without integrating with some third party service. Though it could be exposed as a mod action and automated using a RESTful interface
Easily my least favorite change. Everything else I can see myself getting used to.
Sadly it is necessary right now for emotes. Our old system would break federation so we had to switch to using pictrs instead of our custom renderer. Basically all emotes are now just online images that are made to be small.
Here's the PR from mako
@layla@hexbear.net and @PorkrollPosadist@hexbear.net's original proposal was to have a new database entry for emotes, but Dessalines and Nutomic preferred to use the pictrs solution created by @makotech222@hexbear.net.
Not sure if there will be a way to filter the inline functionality from the emote functionality though. You'll have to ask one of those devs.
We have a nice hook for images that are inline but not emojis, so we just need to decide what we want to do.
So there's a way for the emotes to be separated from inline images without just looking at the markdown formatting? That's good.
In that case couldn't the images just be switched from rendered to rendered as a link (e.g. inline image) pretty easily. That would also make having a user setting toggle pretty easy right? Just choose how you want to render them.
Yeah we'll think of a proper way to handle em. linkifying them is a good idea though, as an option.
Thanks for all your hard work by the way, been reading through all your PRs and discussions on GitHub and you've done fantastic.