Dudes claiming they are "old stock" or "heritage" Americans. They'll even call other white people who's ancestors weren't here before the Civil War "ellis islanders" and invaders.
As someone who's ancestry has partially been here since the 1690s.. it's a crock of shit and silly as fuck.
Scots-Irish. Scotch is a drink. Unless you mean they were Irish but loved Scottish whisky.
Yeah I've seen it said before. Just in america scotch is often used, so I'm used to using that terminology.
fair, and of course it could be argued that that usage is common enough in America that it's valid American-English.
But if you go to Ireland or especially Scotland, and talk about Scotch-Irish, people will either mock you openly or keep it politely to themselves and silently judge you ;). All they'll hear is "I'm whisky-Irish".